add clkrstSetMinVClockRate() and clkrstGetDvfsTable() - #734
Merged
Merged
Conversation
yellows8
reviewed
Jun 29, 2026
| return rc; | ||
| } | ||
|
|
||
| Result clkrstSetMinVClockRate(ClkrstSession *session, u32 hz) { |
Contributor
There was a problem hiding this comment.
Cmds should be in cmdid-order. Move this before clkrstGetPossibleClockRates.
Contributor
There was a problem hiding this comment.
This should also be clkrstSetMinimumVoltageClockRate.
yellows8
approved these changes
Jun 30, 2026
Contributor
Author
|
Realized that the firmware checks didn't make much sense since clkrst was only added after 8.0.0 anyway, I accidentally confused it with the older pcv versions, my bad. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.